[phc-general] auto{conf,make} portability patch

Edsko de Vries edsko at phpcompiler.org
Sat Dec 30 11:14:40 CET 2006


Hi Conor,

First of, thanks for your long bug report. However, I have actually
build phc on Mac OS X, without difficulties. You are right in saying
that -rdynamic is not recognised by gcc, but I found that it simply
ignores it, rather than trowing up an error and aborting compilation -
which is why I haven't bothered so far to remove it (as far as I
remember, on the Suns, -rdynamic is unnecessary too, but also ignored).
Did gcc on your Mac actually stop compilation, or just complain error
and continue? Of course, not checking if -rdynamic is required was just
laziness on my part, so now that you've done the work, I'll gladly apply
the patch :-) 

> There's one smaller fix in Makefile.am which removes the assumption that
> the php in your path at make time is the one you want to use. I can't
> remove that assumption from some of the tests, so some of them are
> unnecessarily failing. I'm going to follow up with a patch for that
> soon.

The test framework has actually changed quite a bit since then, and Paul
has already integrated configure with the tests (the tests now include
an autovars.php, generated from autovars.php.in by configure) - so don't
bother for the moment. If the new release (or I could send you a
pre-release if you want) still doesn't solve these problems, let us know.

> I'm available for further testing of anything you guys come up with. My
> autotools-foo is weak, so apologies  if I've committed a heinous crime
> in my addition to configure.ac. :-) If my patch doesn't work, then I
> should be able to figure out why if you post the output of 'gcc
> --version', 'gcc -dumpspecs' and 'uname -a'.

I've just run it and it seems to work, both on my machine (Debian/x86)
and on my Sun.  

As for further testing, we are currently working on the code generator,
which is coming along nicely, but will it will take some time to get it
finished :) 

> Happy New Year,

You too, and thanks again,

Edsko



More information about the phc-general mailing list