[phc-internals] [phc commit] r1813 - trunk/test/framework

codesite-noreply at google.com codesite-noreply at google.com
Sat Oct 25 18:14:07 IST 2008


Author: paul.biggar
Date: Sat Oct 25 10:13:03 2008
New Revision: 1813

Modified:
    trunk/test/framework/generate_c.php

Log:
The generate_c test counts the number of lines in the generated code,  
which, for 300000 lines of generated code line constant_fold.php, takes a  
very long time. Instead, use strlen, and check against the size of the code  
generated for a blank file, which is O(1).


Modified: trunk/test/framework/generate_c.php
==============================================================================
--- trunk/test/framework/generate_c.php	(original)
+++ trunk/test/framework/generate_c.php	Sat Oct 25 10:13:03 2008
@@ -41,7 +41,7 @@
  				"exit or error set");
  		}
  		# Blank output wasnt being picked up
-		else if (count (split ("\n", $phc_out)) < 170)
+		else if (strlen ($phc_out) < 1428)
  		{
  			$this->mark_failure ($subject, $phc_command, $phc_exit, $phc_out,  
$phc_err, "output is too short");
  		}


More information about the phc-internals mailing list